Personally, I believe long tossing is more effective. It forces your body to continually adapt and improves your ability to throw longer which increases your arm speed. For me, it doesn't matter if it is on a line or in the air. You are trying to increase arm strength/arm speed, so the direction the ball goes is irrelevant.